Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Propogate user defined labels on the RGI to resources #229

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Propogate user defined labels on the RGI to resources #229

wants to merge 3 commits into from

Conversation

RinkiyaKeDad
Copy link
Contributor

This PR allows the user to propogate the labels they have set on the Resource Group Instance by using setting the kro.run/propagate-labels: "true" annotation.

Fixes #184

Sample RGI to try it out with:

apiVersion: kro.run/v1alpha1
kind: Something
metadata:
  name: my-something-instance
  annotations:
    kro.run/propagate-labels: "true"
  labels:
    this: works
spec:
  name: my-awesome-app
  ingress:
    enabled: false

Use the RG from the getting started guide with this.

@RinkiyaKeDad
Copy link
Contributor Author

@a-hilaly I wasn't able to figure out where to write the tests for this, can you please point me in the right direction?

@RinkiyaKeDad
fix merge conflicts
ad9101f 
Signed-off-by: Arsh Sharma <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

propagate RGI labels to managed resources
1 participant
@RinkiyaKeDad